Migrate to clap 4 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Jan 13, 2023
|
Ah, I missed the last two commits - I would prefer to put those in a follow-up PR if possible, the clap migration is already quite large. |
jyn514
reviewed
Jan 13, 2023
|
I'll be separating the last two commits for the next PR. 👍 |
I wanted to do it in even smaller pieces, but the migration commit had to do a lot of stuff at the same time. I unindented most of the
You'll have 60 fewer modifications to review in that commit 😉. |
marcospb19
force-pushed
the
migrate-to-clap-4
branch
from
c581cf9
to
a1ae53d
Compare
now when running it like `cargo sweep`, the --version is available, which is necessary for when cargo-sweep is ran via cargo, also, --help shows the crate description (from TOML manifest)
marcospb19
force-pushed
the
migrate-to-clap-4
branch
from
a1ae53d
to
a984b42
Compare
by considering that files can be outputted in different order
marcospb19
force-pushed
the
migrate-to-clap-4
branch
from
a984b42
to
3f49346
Compare
jyn514
approved these changes
Jan 31, 2023
marcospb19
force-pushed
the
migrate-to-clap-4
branch
from
c0c7cb7
to
f8bb6f8
Compare
This was referenced Feb 1, 2023
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from
clap 2toclap 4, and does a littlebit of refactoring on the code that it touches.
Fixes #86.
It also adds
-mas a short flag for--maxsize.